Skip to content

Conversation

@alexwilson1
Copy link
Contributor

@alexwilson1 alexwilson1 commented Jul 20, 2025

Pull Request Summary

Thank you for creating such an awesome project! DetoxDroid is a fantastic tool for digital wellness, and I'm excited to contribute these improvements.

🚀 Main Changes

1. Simplified Signing Configuration

  • Moved from third-party dependency (ilharp/sign-android-release@nightly) to direct Gradle configuration (simplification and remove a potential point of supply chain vulnerability).

2. Enhanced Grayscale Filter UX

  • Made inclusion/exclusion list toggle more obvious and discoverable
  • Added clear "Filter Mode" setting with "Exclude Apps" vs "Include Apps" options
  • Integrated the toggle directly into the grayscale settings screen
image

3. Improved Build System

  • Fixed builds for cold-started repos and forks
    • Enhanced CI/CD pipeline to handle initial releases properly
    • Better version bump logic and commit range analysis

4. Removed Root Functionality

  • Eliminated third-party RootShell dependency (com.github.Stericson:RootShell:1.6)
  • Dependency was unmaintained, potentially insecure, and causing build issues due to this new error
  • Root users can typically run ADB commands anyway, so minimal benefit lost

5. Finer Grayscale Control

  • Changed daily color screen time settings from 15-minute to 5-minute increments
  • Allows for more precise user customization

I think that including third-party dependencies should be last resort, especially since the permissions requested by the app are so wide (required for it's functionality).

alexwilson1 and others added 22 commits July 20, 2025 12:26
… exception list type selection in GrayscaleAppsFeatureSettingsSection
…ist type, and integrate with GrayscaleAppsFeatureSettingsSection
@alexwilson1 alexwilson1 force-pushed the master branch 2 times, most recently from 0b9d20d to 52e6a8f Compare August 8, 2025 20:08
@alexwilson1 alexwilson1 deleted the branch flxapps:master August 8, 2025 20:09
@alexwilson1 alexwilson1 closed this Aug 8, 2025
@alexwilson1 alexwilson1 deleted the master branch August 8, 2025 20:09
@alexwilson1 alexwilson1 restored the master branch September 2, 2025 02:25
@alexwilson1 alexwilson1 reopened this Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants