Upgrade golang.org/x/crypto lib to address vulnerability#6133
Merged
Upgrade golang.org/x/crypto lib to address vulnerability#6133
Conversation
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Collaborator
Code Review Agent Run #a02962Actionable Suggestions - 0Review Details
AI Code Review powered by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6133 +/- ##
=======================================
Coverage 37.01% 37.01%
=======================================
Files 1318 1318
Lines 132525 132525
=======================================
+ Hits 49052 49054 +2
+ Misses 79228 79226 -2
Partials 4245 4245
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Changelist by BitoThis pull request implements the following key changes.
|
Future-Outlier
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
As detailed in https://cve.mitre.org/cgi-bin/cvename.cgi?name=2024-45337, the crypto library contains a vulnerability that may be susceptible to an authorization bypass
This CVE suggests that this is mitigated in v0.31.0
What changes were proposed in this pull request?
See PR title
How was this patch tested?
Verified flyte single binary compiled and tests passed.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
Critical security update to address CVE-2024-45337 by upgrading golang.org/x/crypto from various older versions to v0.31.0 across multiple Flyte components. The update includes related golang.org/x dependencies (sync, sys, term, text) to ensure compatibility and maintain system security.Unit tests added: False
Estimated effort to review (1-5, lower is better): 5