Remove misleading address field from Ray Task#2870
Remove misleading address field from Ray Task#2870Sovietaced wants to merge 1 commit intoflyteorg:masterfrom
Conversation
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2870 +/- ##
===========================================
+ Coverage 45.53% 92.37% +46.83%
===========================================
Files 196 126 -70
Lines 20418 5417 -15001
Branches 2647 0 -2647
===========================================
- Hits 9298 5004 -4294
+ Misses 10658 413 -10245
+ Partials 462 0 -462 ☔ View full report in Codecov by Sentry. |
wild-endeavor
left a comment
There was a problem hiding this comment.
This is backwards incompatible right?
Correct. If we want to keep backwards compatibility I can close this. I was't sure how stable these plugins are meant to be, especially this one. |
| self._task_config = task_config | ||
|
|
||
| def pre_execute(self, user_params: ExecutionParameters) -> ExecutionParameters: | ||
| init_params = {"address": self._task_config.address} |
There was a problem hiding this comment.
thanks. I think this only works for local execution. For those people who still want to use it, they can use RAY_ADDRESS env.
Tracking issue
Closes flyteorg/flyte#5877
Why are the changes needed?
The documentation implies that you can run a ray job on an existing cluster by configuring the address but this is not true since the task still requires users to configure details for a new and dynamically created Ray Cluster. And ray jobs will run on the dynamically created Ray Cluster even if an address is configured.
Check all the applicable boxes
Related PRs
flyteorg/flytesnacks#1765