-
Notifications
You must be signed in to change notification settings - Fork 5
chore(ver): Update OLS version to latest #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Php8.4 support
This reverts commit f4d231c.
WalkthroughThe Dockerfile for OpenLiteSpeed was updated to change the build argument specifying the OpenLiteSpeed version from 1.8.3 to 1.8.4, adjusting the download URL accordingly. No other logic or structural changes were made. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
openlitespeed/Dockerfile (1)
26-28
: Add integrity verification for downloaded tarball
wget
+ untar without any checksum or signature verification leaves the build susceptible to supply-chain attacks or silent corruption.
Consider verifying a published SHA-256 (or GPG signature) before extraction:&& wget -q "https://openlitespeed.org/packages/openlitespeed-$OLS_VERSION-$ARCH-linux.tgz" -O /tmp/ols.tgz \ -&& tar xzf openlitespeed-$OLS_VERSION-$ARCH-linux.tgz \ +&& echo "<expected-sha256 /tmp/ols.tgz>" | sha256sum -c - \ +&& tar -xzf /tmp/ols.tgz \ && cd openlitespeed && ./install.sh \(Replace
<expected-sha256>
with the official hash once published.)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
openlitespeed/Dockerfile
(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: ma-04
PR: flywp/dockerfiles#20
File: .github/workflows/test.yml:63-65
Timestamp: 2025-06-26T03:58:59.767Z
Learning: OpenLiteSpeed does not support PHP 8.0, which is why it's excluded from OLS Docker image build matrices while being included in regular PHP matrices.
📚 Learning: openlitespeed does not support php 8.0, which is why it's excluded from ols docker image build matri...
Learnt from: ma-04
PR: flywp/dockerfiles#20
File: .github/workflows/test.yml:63-65
Timestamp: 2025-06-26T03:58:59.767Z
Learning: OpenLiteSpeed does not support PHP 8.0, which is why it's excluded from OLS Docker image build matrices while being included in regular PHP matrices.
Applied to files:
openlitespeed/Dockerfile
🔇 Additional comments (1)
openlitespeed/Dockerfile (1)
7-7
: All OpenLiteSpeed 1.8.4 artefacts confirmed for x86_64 and aarch64Both package URLs returned HTTP 200:
- https://openlitespeed.org/packages/openlitespeed-1.8.4-x86_64-linux.tgz
- https://openlitespeed.org/packages/openlitespeed-1.8.4-aarch64-linux.tgz
No further action required before merging.
Chores