Feature/add snapshot functionalities#362
Conversation
bilal-naeem-confiz
left a comment
There was a problem hiding this comment.
Please make the suggested changes. Also, add an integration test for this feature.
There was a problem hiding this comment.
In case of asynchronous calls, you will have to modify the response to return a Fog::AsyncResponse object. You can see it here
There was a problem hiding this comment.
Typo in managedisk. Should be managed disk.
There was a problem hiding this comment.
This should be unless instead of if
| class AzureRM | ||
| # Real class for Compute Request | ||
| class Real | ||
| def delete_snapshot(resource_group_name, snapshot_name, async = false) |
There was a problem hiding this comment.
If this request is called asynchronously, then the response return should be as done here
test/models/compute/test_snapshot.rb
Outdated
There was a problem hiding this comment.
This method will be updated once you update your delete method for asynchronous calls.
There was a problem hiding this comment.
This method will be updated once you update your delete method for asynchronous calls.
There was a problem hiding this comment.
Typo in Resource
|
@bilal-naeem-confiz Excuse the tardly reply. Your requests are been done. |
|
@bilal-naeem-confiz can we have some news about this pull request ? |
|
What's the status of this PR? Would really like to see that integrated. Happy to help if there are any ToDos left. |
|
@stiller-leser @KevinLoiseau |
|
@bilal-naeem-confiz Have you got some news on this pull request ? |
|
For now I created a fork here: https://github.com/stiller-leser/fog-azure-rm that contains the changes. Would be awesome to see this PR merged though. |
|
@KevinLoiseau do you happen to have an example on how to actually create a snapshot? This is missing in the documentation of the README. EDIT: Nevermind, got it to work: And to create a disk from the snapshot: |
@bilal-naeem-confiz @maham-nazir-confiz This is the single PR which contains each functionalities, as you asked.