Conversation
houndci-bot
reviewed
Mar 31, 2018
| @location || 'eastus'.freeze | ||
| end | ||
|
|
||
| def self.location=(location) |
There was a problem hiding this comment.
Use attr_writer to define trivial writer methods.
Member
Author
|
@maham-nazir-confiz Could you please take a look at this PR please? Thanks! |
Member
Author
Contributor
|
@plribeiro3000 Regards |
Member
Author
|
@maham-nazir-confiz Any chance to review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've started this to change usage of
requiretoautoloadbut i did find some stuff that worried me so i've also fixed theLOCATIONConstant.I would like to ask you guys why are you using plain constants and methods out of the
Fog::AzureRMnamespace?This would give clashing issues to the end user if he defines methods or Constants with the same names. We need to move everything to the
Fog::AzureRmnamespace.Since there is a ton of changes, i will send the rest in another PR once this one gets merged.