Add compute image model

[KevinLoiseau]

Hi !

In this PR you will find:

• Add Image model with destroy and save methods
• Add Images collection with get and create methods
• Enhance the create_image request to be able to create image from Virtual Machine or from Managed Disk

UPDATE:

• Add request to list images
• Add methods all to images collection

Thanks !

[maham-nazir-confiz]

Hi @KevinLoiseau
I have reviewed your PR.
It breaks when trying to create an image from a virtual machine. It throws the exception that

The operation 'Create Image' requires the Virtual Machine 'TestVM-Managed' to be Generalized.

Please take a look at this link => https://docs.microsoft.com/en-us/azure/virtual-machines/linux/capture-image

It mentions all the steps that need to be done before a VM can be captured. Update the PR accordingly.
Add an integration test for this as well.

Thank you.
Regards

[KevinLoiseau]

Hi @maham-nazir-confiz
Thank you for your feedback.

I had this error during my tests of this functionnallity but it was not a code's issue; like your link describe you have to "generalized" your dellocated Vm before trying to create an image of it.
For this you have to use this method: https://github.com/fog/fog-azure-rm/blob/master/lib/fog/azurerm/models/compute/server.rb#L127-L130.

I don't think the generalization of the VM should be orchestred by the create_image request, IMHO this is the responsability of the gem user to know prerequisites, and the error raised by the SDK gem is pretty clear. WDYT ?

Regards,
Kevin

[maham-nazir-confiz]

@KevinLoiseau
Yes I think that's fine. The user should first power off and generalize the VM.
I need you to make the following changes in your PR

• Add the instructions in the docs for the user to first power off and then generalize the VM before creating an image.
• Add an integration test that tests all the methods (new and previous) for the images
• Incorporate HoundCI feedback
• Your PR breaks for the destroy method because it calls the delete_image method that further attaches the suffix -osImage to the image name passed to it. Whatever changes you make to fix this, please ensure that if any other class is using this method as well, it doesn't break for them.

Thank you.
Regards

[abbas-sheikh-confiz]

It should be "".

[abbas-sheikh-confiz]

Typo, remove the double dots.