Skip to content

[CF] improve logging and error handling#434

Open
MSSedusch wants to merge 4 commits intofog:fog-arm-cffrom
MSSedusch:fog-arm-cf
Open

[CF] improve logging and error handling#434
MSSedusch wants to merge 4 commits intofog:fog-arm-cffrom
MSSedusch:fog-arm-cf

Conversation

@MSSedusch
Copy link

Improvements:

  • add another rescue case to catch all errors and log them
  • add correlation id to logs to be able to map put_block, create_block and delete_block operations

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/RescueStandardError: Avoid rescuing without specifying an error class.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/RescueStandardError: Avoid rescuing without specifying an error class.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/RescueStandardError: Avoid rescuing without specifying an error class.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/RescueStandardError: Avoid rescuing without specifying an error class.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/TrailingWhitespace: Trailing whitespace detected.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NegatedIf: Favor unless over if for negative conditions.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NegatedIf: Favor unless over if for negative conditions.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NegatedIf: Favor unless over if for negative conditions.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NegatedIf: Favor unless over if for negative conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments