ERM 3654: Replace HttpBuilderNg with Micronaut Http Client #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or request and response handling
|
License CLA Stuck? (Developer should make sure that it is really stuck before clicking) |
Contributor
|
Things for discussion here... namely these shouldn't all be relying on GokbClient and I think there's still need for a webSourceAdapter... We can potentially handle this with an "AdapterClient" interface or otherwise and then have the websource adapter code utilise one of those.... Alternatively if we're going separate per adapter (which might be the right model... I haven't thought about this totally yet) then my gut instinct says that we need to set up dummy clients for the other adapters, they can just throw "Is not implemented" for now though since those adapters aren't used.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.