Skip to content

Conversation

@mchaib-k-int
Copy link
Contributor

@mchaib-k-int mchaib-k-int commented Jul 3, 2025

Based on these comments from the original PR, had a go at keeping the webSourceAdapter but having it use a client interface, which each adapter that extends WSA must provide an implementation for.

Still needs a bit of work to get all the WebSourceAdapters methods using methods from the new interface (I only implemented getSync so far)

My thoughts:

  • Now the WebSourceAdapter and Adapters themselves don't know anything about the http client used to make requests. If we decide to swap out the client, we shouldn't have to make a change to WebSourceAdapter or the other adapters.
  • For now the getData on the adapter interface just accepts the URL and a Map of parameters. This could be extended (so e.g. all client adapter implementations MUST implement a getData(..., Auth stuff)/getDataAuth() method).
  • The GoKBClient and KIJPFClient implementations could look quite similar (set up micronaut client, make requests etc...)- do we also want an abstract client class which would implement the methods from the AdapterClient interface, then the GoKbClient and KIJPF clients extend that?

"Things for discussion here... namely these shouldn't all be relying on GokbClient and I think there's still need for a webSourceAdapter... We can potentially handle this with an "AdapterClient" interface or otherwise and then have the websource adapter code utilise one of those.... Alternatively if we're going separate per adapter (which might be the right model... I haven't thought about this totally yet) then my gut instinct says that we need to set up dummy clients for the other adapters, they can just throw "Is not implemented" for now though since those adapters aren't used...."

…s for each adapter. rework web adapter for new client interface
@github-actions
Copy link

github-actions bot commented Jul 3, 2025

License CLA Stuck? (Developer should make sure that it is really stuck before clicking)

@github-actions
Copy link

github-actions bot commented Jul 3, 2025

Test Results

 27 files  ±0   27 suites  ±0   11m 15s ⏱️ +23s
647 tests ±0  643 ✅ ±0  4 💤 ±0  0 ❌ ±0 
648 runs  ±0  644 ✅ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 2412238. ± Comparison against base commit 7846ef8.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants