Skip to content

Conversation

@EthanFreestone
Copy link
Contributor

@EthanFreestone EthanFreestone commented Dec 17, 2025

This sets up mod-licenses to use the AccessControl grails plugin making use of the underlying AccessControl engine.

THIS IS CURRENTLY NOT FULLY TESTED

Needs testing

  • Custom applyAmendment in show in LicenseController
  • Custom delete behaviour in LicenseController

@github-actions
Copy link

License CLA Stuck? (Developer should make sure that it is really stuck before clicking)

@github-actions
Copy link

Test Results

61 tests  ±0   61 ✅ ±0   24s ⏱️ +2s
 4 suites ±0    0 💤 ±0 
 4 files   ±0    0 ❌ ±0 

Results for commit 6038f28. ± Comparison against base commit 8d41e6f.

This pull request removes 36 and adds 36 tests. Note that renamed tests count towards both.
org.olf.licenses.LicenseAmendmentSpec ‑ Add License Properties [payload: <org.olf.licenses.LicenseAmendmentSpec$__spock_feature_2_1prov0_closure2@4c46360e delegate=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab owner=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab thisObject=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, #0]
org.olf.licenses.LicenseAmendmentSpec ‑ Add License Properties [payload: <org.olf.licenses.LicenseAmendmentSpec$__spock_feature_2_1prov0_closure3@75520f8d delegate=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab owner=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab thisObject=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, #1]
org.olf.licenses.LicenseAmendmentSpec ‑ Add License Properties [payload: <org.olf.licenses.LicenseAmendmentSpec$__spock_feature_2_1prov0_closure4@2fdf1dec delegate=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab owner=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab thisObject=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, #2]
org.olf.licenses.LicenseAmendmentSpec ‑ Add License Properties [payload: <org.olf.licenses.LicenseAmendmentSpec$__spock_feature_2_1prov0_closure5@66d79072 delegate=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab owner=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab thisObject=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, #3]
org.olf.licenses.LicenseAmendmentSpec ‑ Add Licenses [payload: <org.olf.licenses.LicenseAmendmentSpec$__spock_feature_2_2prov0_closure7@5ccc684f delegate=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab owner=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab thisObject=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, termData: [concurrentAccess:[internal:true, note:Note for concurrentAccess, publicNote:Public note for concurrentAccess], authorisedUsers:[internal:false, note:Note for authorisedUsers, publicNote:Public note for authorisedUsers], remoteAccess:[internal:false], illElectronic:[internal:true]], #0]
org.olf.licenses.LicenseAmendmentSpec ‑ Add Licenses [payload: <org.olf.licenses.LicenseAmendmentSpec$__spock_feature_2_2prov0_closure8@10c9b823 delegate=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab owner=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab thisObject=org.olf.licenses.LicenseAmendmentSpec@3c5a9eab resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, termData: [concurrentAccess:[internal:false], authorisedUsers:[internal:true], remoteAccess:[internal:true], illElectronic:[internal:false]], #1]
org.olf.licenses.LicenseAmendmentSpec ‑ Add amendments to license 0d69d5e8-481a-4365-b9b4-484a09bfc09e
org.olf.licenses.LicenseAmendmentSpec ‑ Add amendments to license b8f926b5-addc-4902-8d6e-b66bed76515b
org.olf.licenses.LicenseAmendmentSpec ‑ Remove amendment from 0d69d5e8-481a-4365-b9b4-484a09bfc09e
org.olf.licenses.LicenseAmendmentSpec ‑ Remove amendment from b8f926b5-addc-4902-8d6e-b66bed76515b
…
org.olf.licenses.LicenseAmendmentSpec ‑ Add License Properties [payload: <org.olf.licenses.LicenseAmendmentSpec$__spock_feature_2_1prov0_closure2@44034c25 delegate=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 owner=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 thisObject=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, #0]
org.olf.licenses.LicenseAmendmentSpec ‑ Add License Properties [payload: <org.olf.licenses.LicenseAmendmentSpec$__spock_feature_2_1prov0_closure3@6138abaf delegate=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 owner=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 thisObject=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, #1]
org.olf.licenses.LicenseAmendmentSpec ‑ Add License Properties [payload: <org.olf.licenses.LicenseAmendmentSpec$__spock_feature_2_1prov0_closure4@826cde4 delegate=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 owner=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 thisObject=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, #2]
org.olf.licenses.LicenseAmendmentSpec ‑ Add License Properties [payload: <org.olf.licenses.LicenseAmendmentSpec$__spock_feature_2_1prov0_closure5@782c8806 delegate=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 owner=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 thisObject=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, #3]
org.olf.licenses.LicenseAmendmentSpec ‑ Add Licenses [payload: <org.olf.licenses.LicenseAmendmentSpec$__spock_feature_2_2prov0_closure7@48643026 delegate=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 owner=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 thisObject=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, termData: [concurrentAccess:[internal:true, note:Note for concurrentAccess, publicNote:Public note for concurrentAccess], authorisedUsers:[internal:false, note:Note for authorisedUsers, publicNote:Public note for authorisedUsers], remoteAccess:[internal:false], illElectronic:[internal:true]], #0]
org.olf.licenses.LicenseAmendmentSpec ‑ Add Licenses [payload: <org.olf.licenses.LicenseAmendmentSpec$__spock_feature_2_2prov0_closure8@bd71e79 delegate=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 owner=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 thisObject=org.olf.licenses.LicenseAmendmentSpec@24bd4b62 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, termData: [concurrentAccess:[internal:false], authorisedUsers:[internal:true], remoteAccess:[internal:true], illElectronic:[internal:false]], #1]
org.olf.licenses.LicenseAmendmentSpec ‑ Add amendments to license 08ad965e-1c5d-4e2b-af7f-406b141542ee
org.olf.licenses.LicenseAmendmentSpec ‑ Add amendments to license a9beda83-5325-4365-a0a2-77f30230c50d
org.olf.licenses.LicenseAmendmentSpec ‑ Remove amendment from 08ad965e-1c5d-4e2b-af7f-406b141542ee
org.olf.licenses.LicenseAmendmentSpec ‑ Remove amendment from a9beda83-5325-4365-a0a2-77f30230c50d
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants