Skip to content

Conversation

@mchaib-k-int
Copy link
Contributor

Builds locally and passes integration tests.

upgrades grailsVersion=6.1.1 to grailsVersion=6.2.3
upgrades "org.grails.plugins:spring-security-core:6.1.1" to "org.grails.plugins:spring-security-core:6.1.2"

Also comments out/removes the implementation("org.springframework.security:spring-security-core:5.8.11") dependency - is this necessary when we are pulling in the grails spring security core? It didn't affect the build or integration tests locally but unsure if this is required for deployment.

Dependencies export-
upgrade-deps.txt

@github-actions
Copy link

github-actions bot commented May 29, 2025

Test Results

42 tests  ±0   42 ✅ ±0   1m 15s ⏱️ ±0s
 6 suites ±0    0 💤 ±0 
 6 files   ±0    0 ❌ ±0 

Results for commit f2ee077. ± Comparison against base commit 378df28.

♻️ This comment has been updated with latest results.

@mchaib-k-int mchaib-k-int changed the title feat: upgrade grails to 6.2.3 and spring-core-security plugin to 6.1.2 ERM-3306: Dependency upgrades May 29, 2025
@mchaib-k-int mchaib-k-int marked this pull request as draft June 4, 2025 08:07
Copy link

@julianladisch julianladisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@EthanFreestone
Copy link
Contributor

Closing, this will be picked up instead by #187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants