Skip to content

Conversation

@Dmytro-Melnyshyn
Copy link
Contributor

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Nov 21, 2025

Purpose

The failing tests are related to the migration of the stripes-acq-components to @folio/jest-config-stripes. The best approach to fix tests is to also migrate to @folio/jest-config-stripes and then to not depend on stripes-acq-components tests config - the latter will be implemented in https://folio-org.atlassian.net/browse/UICIRCLOG-184.

Approach

Issues

https://folio-org.atlassian.net/browse/UICIRCLOG-182

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Jest Unit Test Results

101 tests  +25   101 ✅ +25   1m 54s ⏱️ +10s
 15 suites + 1     0 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit a494cab. ± Comparison against base commit 88399a3.

This pull request removes 1 and adds 26 tests. Note that renamed tests count towards both.
useCirculationLogExport when buildLogEventsQuery is called should pass timezone ‑ useCirculationLogExport when buildLogEventsQuery is called should pass timezone
Circulation Log List Container displays Circulation Log List ‑ Circulation Log List Container displays Circulation Log List
Circulation Log List Container fetches service points ‑ Circulation Log List Container fetches service points
Circulation Log List Container should fetch records by running two requests, one with a zero limit to get the total number of records, and one to get the records ‑ Circulation Log List Container should fetch records by running two requests, one with a zero limit to get the total number of records, and one to get the records
Managing focus for date range filter with initial results ‑ Managing focus for date range filter with initial results
Managing focus for date range filter with no initial results ‑ Managing focus for date range filter with no initial results
Managing focus for mixed filters interaction with initial results ‑ Managing focus for mixed filters interaction with initial results
Managing focus for mixed filters interaction with no initial results ‑ Managing focus for mixed filters interaction with no initial results
Managing focus for text filter "description" flow: initial results - no results - with results ‑ Managing focus for text filter "description" flow: initial results - no results - with results
Managing focus for text filter "description" flow: initial results - with results - no results ‑ Managing focus for text filter "description" flow: initial results - with results - no results
Managing focus for text filter "description" flow: no results - no results - with results ‑ Managing focus for text filter "description" flow: no results - no results - with results
…

♻️ This comment has been updated with latest results.

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team November 21, 2025 09:44
@sonarqubecloud
Copy link

@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit a7de657 into master Nov 25, 2025
15 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UICIRCLOG-182 branch November 25, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants