Skip to content

Conversation

@Dmytro-Melnyshyn
Copy link
Contributor

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Nov 26, 2025

Purpose

Importing test infrastructure from source paths in stripes-acq-components is not a viable long-term solution. That's a private path, not a public declaration, so it's subject to change without warning. Use Jest configuration from @folio/jest-config-stripes insted of @folio/stripes-acq-components/jest.config.

Issues

https://folio-org.atlassian.net/browse/UICIRCLOG-184

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@github-actions
Copy link

Jest Unit Test Results

101 tests  ±0   101 ✅ ±0   1m 58s ⏱️ +2s
 15 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 660fb48. ± Comparison against base commit a7de657.

@sonarqubecloud
Copy link

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested review from a team and mariia-aloshyna November 26, 2025 14:57
@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit 723c022 into master Nov 27, 2025
15 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UICIRCLOG-184 branch November 27, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants