Add a utility for determining the display of users on a request #1343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In discussing the expected interactions between requesters and proxies it turns out that it is rather complicated. Display of the Proxy user information depends on the Requester information. There's also a quite complicated interplay between the requesterId and requester properties in determining whether a user is anonymized or unknown.
Previously #1336 and #1337 were opened and iterated upon. Based on new information learned about the feature I thought it might be easier to start fresh with a different approach.
Purpose
Requests will be able to be anonymized soon. The current UI does not break when this happens but displays Unknown instead of Anonymized. This PR is intended to keep the display of requests consistent with what is actual stored.
Approach
The first step is to take all of the necessary context in one place to determine the eventual display of requesters and proxies. If this approach is accepted the code to actual use the computed will be implemented.
Refs
Screenshots
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.