UIREQ-1344: Migrate tag flag from mod-configuration to mod-settings #1345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dmitriy-Litvinenko
force-pushed
the
UIREQ-1344
branch
from
a98b07d to
0fe2b27
Compare
|
dmitry-melnishin
previously approved these changes
Dec 17, 2025
Dmytro-Melnyshyn
approved these changes
Dec 17, 2025
Dmitriy-Litvinenko
requested review from
Dmytro-Melnyshyn and
dmitry-melnishin
and removed request for
dmitry-melnishin
Dmytro-Melnyshyn
requested review from
dmitry-melnishin
and removed request for
dmitry-melnishin
Dmitriy-Litvinenko
dismissed
dmitry-melnishin’s stale review
Second approval from one person
Dmitriy-Litvinenko
requested review from
dmitry-melnishin
and removed request for
dmitry-melnishin
Dmytro-Melnyshyn
approved these changes
Dec 17, 2025
Dmytro-Melnyshyn
requested review from
a team and
dmitry-melnishin
and removed request for
dmitry-melnishin
zburke
approved these changes
Dec 17, 2025
Member
zburke
left a comment
zburke
left a comment
There was a problem hiding this comment.
tagsScope comes in @folio/stripes v10.1.0, though it is implemented as an opt-in prop so you can choose how to handle it:
- breaking change: update the
package.jsondep on@folio/stripesto^10.1.0to require that tags be persisted through mod-settings; update CHANGELOG to call attention to this*BREAKING*change - optional change: this is OK as is;
tagsScopewill be silently ignored in ~10.0 versions of stripes and tags will persisted through mod-config; when ^10.1 is present then stripes-smart-components will use mod-settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Migrate tag flag from mod-configuration to mod-settings
Refs
https://folio-org.atlassian.net/browse/UIREQ-1344