Skip to content

[W-21857737] revert(apex): roll back defensive LS shutdown changes#7119

Merged
daphne-sfdc merged 1 commit intodevelopfrom
phale/revert-defensive-shutdown
Apr 1, 2026
Merged

[W-21857737] revert(apex): roll back defensive LS shutdown changes#7119
daphne-sfdc merged 1 commit intodevelopfrom
phale/revert-defensive-shutdown

Conversation

@peternhale
Copy link
Copy Markdown
Contributor

What does this PR do?

Reverts the defensive Apex language server shutdown changes so extension deactivation and LS process handling return to the previous behavior.

What issues does this PR fix or reference?

#, @W-21857737@

Functionality Before

A defensive timeout/force-kill path was added during deactivation, JDWP debug port switched to dynamic, and process parsing/kill logic was expanded.

Functionality After

Those changes are removed and behavior is restored to the prior implementation.

Made with Cursor

Restore prior Apex extension deactivation and language server process behavior.
W-21857737

Made-with: Cursor
@peternhale peternhale requested a review from daphne-sfdc April 1, 2026 16:26
@peternhale peternhale changed the title revert(apex): roll back defensive LS shutdown changes W-21857737 [W-21857737] revert(apex): roll back defensive LS shutdown changes Apr 1, 2026
@peternhale peternhale marked this pull request as ready for review April 1, 2026 16:27
@peternhale peternhale requested a review from a team as a code owner April 1, 2026 16:27
Copy link
Copy Markdown
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installed the VSIX from this branch. No longer seeing this warning when reloading VSCode, closing it, or switching between projects ✅
Image

@daphne-sfdc daphne-sfdc merged commit 8924db0 into develop Apr 1, 2026
61 of 71 checks passed
@daphne-sfdc daphne-sfdc deleted the phale/revert-defensive-shutdown branch April 1, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants