chore: enforce knip dead code checks via eslint + CI W-21801858#7150
Open
chore: enforce knip dead code checks via eslint + CI W-21801858#7150
Conversation
kylewalke
reviewed
Apr 8, 2026
|
|
||
| ```bash | ||
| git fetch origin develop | ||
| git checkout develop |
Contributor
There was a problem hiding this comment.
Why do we want to not track the feature branch by default?
kylewalke
approved these changes
Apr 8, 2026
Contributor
kylewalke
left a comment
kylewalke
left a comment
There was a problem hiding this comment.
Since it's mostly removal of dead code and such with the changes to the skills and rules, I think it looks all good. I'd prefer to wait until after tdx though as the changes to remove the exports from so many packages means risk I'd want to avoid before code freeze if something uncaught by testing (e2e/unit/manual) slips through the cracks. I'll approve though and start some manual testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enforces knip dead code detection in CI and local tooling:
knip.jsonconfignoExportTaggedErrorInServiceseslint ruleWhat issues does this PR fix or reference?
@W-21801858@
Made with Cursor