Skip to content

tinystdio: Add a fix for rounding in case of 0 decimal places for fmode #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tinystdio: Add a fix for rounding in case of 0 decimal places for fmode #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
639617b
tinystdio: Add a fix for rounding in case of 0 decimal places for fmode
A-Shehab Jul 10, 2024
9ddc112
Added a testcase to test printf function rounding with 0 precision
A-Shehab Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion newlib/libc/tinystdio/dtoa_ryu.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ d2d(const uint64_t ieeeMantissa, const uint32_t ieeeExponent, int max_digits, bo

// We need to take vr + 1 if vr is outside bounds or we need to round up.
// I don't know if the 'truncate_max' case is entirely correct; need some tests
uint8_t carry = ((!truncate_max && vr == vm && (!acceptBounds || !vmIsTrailingZeros)) || lastRemovedDigit >= 5);
uint8_t carry = (((!truncate_max && vr == vm && (!acceptBounds || !vmIsTrailingZeros)) || lastRemovedDigit >= 5) && !(fmode && max_decimals == 0));
output += carry;

int len = decimalLength17(output);
Expand Down
1 change: 1 addition & 0 deletions test/testcases.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@
result |= test(__LINE__, "8.6000", "%2.4f", 8.6);
result |= test(__LINE__, "0.600000", "%0f", 0.6);
result |= test(__LINE__, "1", "%.0f", 0.6);
result |= test(__LINE__, "0", "%.0f", 0.45);
result |= test(__LINE__, "8.6000e+00", "%2.4e", 8.6);
result |= test(__LINE__, " 8.6000e+00", "% 2.4e", 8.6);
result |= test(__LINE__, "-8.6000e+00", "% 2.4e", -8.6);
Expand Down