fix(logging): migrate request validation to in-app console #913
+58
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foss42#587, foss42#178) - Add validation checks before sending requests - Log empty URL errors with 'empty-url' tag - Log GET requests with body as warnings with 'get-with-body' tag - Validate JSON payloads and log status with 'valid-json'/'invalid-json' tags - Log validation completion summary with 'completed' tag - All validation logs use category: 'validation' and TerminalSource.system This migrates validation messages from transient UI notifications to the persistent in-app terminal console, improving user experience and debugging capabilities. Fixes foss42#906 Fixes foss42#587 Fixes foss42#178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This migrates validation messages from transient UI notifications to the persistent in-app terminal console, improving user experience and debugging capabilities.
Related Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
We encourage you to add relevant test cases.
OS on which you have developed and tested the feature?