Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix Command Injection vulnerability via malicious Git configuration#73

Open
tachyon-beep wants to merge 1 commit into
mainfrom
fix/git-fsmonitor-command-injection-7099007833558316659
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix Command Injection vulnerability via malicious Git configuration#73
tachyon-beep wants to merge 1 commit into
mainfrom
fix/git-fsmonitor-command-injection-7099007833558316659

Conversation

@tachyon-beep

Copy link
Copy Markdown
Collaborator

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Command Injection risk via malicious Git configuration. Subprocess calls to git without core.fsmonitor=false can execute arbitrary commands if a malicious .git/config is present in an untrusted directory.
🎯 Impact: If the static analyzer runs on a directory containing a maliciously crafted .git/config file (e.g., cloned from an untrusted source), it could lead to arbitrary local code execution when the analyzer queries git state.
πŸ”§ Fix: Updated subprocess.run calls that invoke git in src/wardline/core/delta.py and src/wardline/core/legis.py to always pass the "-c", "core.fsmonitor=false" arguments (using the predefined _SAFE_GIT_CONFIG).
βœ… Verification: Ensure the test suite passes (make test) and that git commands now properly disable core.fsmonitor. Checked with uv run pytest tests/unit/core/test_delta.py and the full make test-cov.


PR created automatically by Jules for task 7099007833558316659 started by @tachyon-beep

Disable core.fsmonitor when invoking Git commands via subprocess
to prevent potential command injection via a malicious .git/config
file in an untrusted directory. Added to src/wardline/core/delta.py
and src/wardline/core/legis.py. Also updated unit tests to match.

Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant