Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Local Code Execution via Git Configuration#74

Open
tachyon-beep wants to merge 2 commits into
mainfrom
sentinel-fix-git-lce-13295454441535042016
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Local Code Execution via Git Configuration#74
tachyon-beep wants to merge 2 commits into
mainfrom
sentinel-fix-git-lce-13295454441535042016

Conversation

@tachyon-beep

Copy link
Copy Markdown
Collaborator

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Git commands executed by subprocess without explicit isolation will respect local .git/config files, allowing an attacker to run arbitrary code on the scanning machine when an untrusted repository is parsed.
🎯 Impact: Analyzing an untrusted repository could lead to arbitrary local code execution via the core.fsmonitor git configuration.
πŸ”§ Fix: Always explicitly disable dangerous config variables when executing git commands in Python by injecting ("-c", "core.fsmonitor=false") into the argument list of subprocess.run().
βœ… Verification: Verified by unit tests to make sure that the injected arguments are present in the underlying subprocess execution. Tested codebase with make test successfully.

Also added an entry in .jules/sentinel.md to document the learning.


PR created automatically by Jules for task 13295454441535042016 started by @tachyon-beep

Disables `core.fsmonitor` for all `subprocess.run(["git", ...])` calls when operating on potentially untrusted directories, preventing malicious `.git/config` from executing arbitrary code. Also adds a journal entry to `.jules/sentinel.md` documenting this learning.

Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Disables `core.fsmonitor` for all `subprocess.run(["git", ...])` calls when operating on potentially untrusted directories, preventing malicious `.git/config` from executing arbitrary code. Also adds a journal entry to `.jules/sentinel.md` documenting this learning.

Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant