π‘οΈ Sentinel: [CRITICAL] Fix Local Code Execution via Git Configuration#74
π‘οΈ Sentinel: [CRITICAL] Fix Local Code Execution via Git Configuration#74tachyon-beep wants to merge 2 commits into
Conversation
Disables `core.fsmonitor` for all `subprocess.run(["git", ...])` calls when operating on potentially untrusted directories, preventing malicious `.git/config` from executing arbitrary code. Also adds a journal entry to `.jules/sentinel.md` documenting this learning. Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Disables `core.fsmonitor` for all `subprocess.run(["git", ...])` calls when operating on potentially untrusted directories, preventing malicious `.git/config` from executing arbitrary code. Also adds a journal entry to `.jules/sentinel.md` documenting this learning. Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
π¨ Severity: CRITICAL
π‘ Vulnerability: Git commands executed by
subprocesswithout explicit isolation will respect local.git/configfiles, allowing an attacker to run arbitrary code on the scanning machine when an untrusted repository is parsed.π― Impact: Analyzing an untrusted repository could lead to arbitrary local code execution via the
core.fsmonitorgit configuration.π§ Fix: Always explicitly disable dangerous config variables when executing
gitcommands in Python by injecting("-c", "core.fsmonitor=false")into the argument list ofsubprocess.run().β Verification: Verified by unit tests to make sure that the injected arguments are present in the underlying subprocess execution. Tested codebase with
make testsuccessfully.Also added an entry in
.jules/sentinel.mdto document the learning.PR created automatically by Jules for task 13295454441535042016 started by @tachyon-beep