This repository was archived by the owner on Nov 20, 2020. It is now read-only.
Support for external web console#91
Merged
francescou merged 7 commits intofrancescou:masterfrom Aug 2, 2017
Merged
Conversation
…encies when only frontend app or main.py change
- Added an alternate Dockerfile to local development
Contributor
Author
|
Oh, I forgot to mention that in this PR there are even a couple of small global improvement:
|
Owner
|
Excellent job. Thank you for your contribution! |
Contributor
|
Nice job @kesonno ! I like the ease of swapping out web console implementations, good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all!
I know that this topic was previously discussed several times ( #4 and #83 ).
This is my proposal for add the capability to start a shell inside the container. The basic idea is to decouple the console from the rest of UI, making it possible for the user to choose witch web console to use. This is based on our experience: so far we used docker-compose-ui together with our websocket-based console in a manual fashion, and want to integrate the two but without coupling them, mostly because the server part of our console is written in Go.
The only requirement for a web console is to support passing the container id (or name) and the command to exec as querystring parameters, for eg. with our web console you can call
http://localhost:8888/?cid={containerName}&cmd={command}.Then, you can pass the
WEB_CONSOLE_PATTERNenvironment var to docker-compose-ui, that hold the pattern that will be used to build the url to load the console. Such pattern should include the{containerName}and{command}placeholders.You can try the final result with this
docker-compose.yml:Let me know what you think about this solution! I mention even @MichaelMackus because I've seen he's interested in the topic and he already started experimenting other solution.
Regards
Gennaro