Skip to content

fix: Exchange rate logic and added more api's#1838

Merged
shariquerik merged 7 commits intofrappe:developfrom
shariquerik:exchange-rate-fix
Mar 10, 2026
Merged

fix: Exchange rate logic and added more api's#1838
shariquerik merged 7 commits intofrappe:developfrom
shariquerik:exchange-rate-fix

Conversation

@shariquerik
Copy link
Member

@shariquerik shariquerik commented Mar 10, 2026

Screenshot 2026-03-10 at 2 00 41 PM

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 17.07317% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.28%. Comparing base (14aa51c) to head (7d7855a).
⚠️ Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
crm/api/exchange_rate.py 15.00% 68 Missing ⚠️

❌ Your patch status has failed because the patch coverage (17.07%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1838      +/-   ##
===========================================
- Coverage    53.56%   53.28%   -0.28%     
===========================================
  Files          108      109       +1     
  Lines         5810     5859      +49     
===========================================
+ Hits          3112     3122      +10     
- Misses        2698     2737      +39     
Files with missing lines Coverage Δ
crm/fcrm/doctype/crm_deal/crm_deal.py 89.89% <100.00%> (ø)
.../fcrm/doctype/crm_organization/crm_organization.py 78.94% <100.00%> (ø)
crm/fcrm/doctype/fcrm_settings/fcrm_settings.py 56.66% <ø> (+17.10%) ⬆️
crm/api/exchange_rate.py 15.00% <15.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shariquerik shariquerik merged commit ee9f2bb into frappe:develop Mar 10, 2026
7 checks passed
shariquerik added a commit that referenced this pull request Mar 10, 2026
fix: Exchange rate logic and added more api's (backport #1838)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant