fix: exclude cancelled repost accounting ledgers in the removal of references

[Gubbu77]

Exclude cancelled repost accounting ledgers in _remove_references_in_repost_doctypes, due to this cannot delete the invoices.

repost_doc.save() - saving cancelled document!!

Summary by CodeRabbit

• Chores

  • Released version 15.93.1

• Bug Fixes

  • Enhanced reconciliation processes to exclude cancelled documents from reprocessing, ensuring only active records are affected by account updates.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This pull request includes a version bump and a refinement to document reference handling. The version number in the main module is incremented from 15.92.5 to 15.93.1. Additionally, a filtering criterion is added to the reference removal logic in the accounts controller to exclude cancelled documents (docstatus 2) from processing, narrowing the scope of documents considered in the reference handling workflow.

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title directly and specifically describes the main change: excluding cancelled repost accounting ledgers in the removal of references, which aligns with the core fix implemented in accounts_controller.py.

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5955b69 and 7b209e9.

📒 Files selected for processing (2)

• erpnext/__init__.py
• erpnext/controllers/accounts_controller.py

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-12-16T05:33:58.723Z

Learnt from: Abdeali099
Repo: frappe/erpnext PR: 51078
File: erpnext/accounts/doctype/financial_report_template/financial_report_engine.py:486-491
Timestamp: 2025-12-16T05:33:58.723Z
Learning: In ERPNext/Frappe codebase, query.run(as_dict=True) returns frappe._dict objects that support both dict-style access (obj["key"]) and attribute-style access (obj.key). Therefore, attribute access on query results is valid and will not raise AttributeError. When reviewing Python code, prefer attribute access (obj.key) for readability where the key is known to exist, but ensure existence checks or fallback handling if there is any doubt about missing keys.

Applied to files:

• erpnext/__init__.py
• erpnext/controllers/accounts_controller.py

🧬 Code graph analysis (1)

erpnext/controllers/accounts_controller.py (4)

erpnext/stock/doctype/stock_entry/stock_entry.js (1)

• dt (781-781)

erpnext/public/js/controllers/transaction.js (1)

• doctype (2736-2736)

erpnext/selling/page/point_of_sale/pos_controller.js (1)

• name (562-562)

erpnext/selling/page/point_of_sale/pos_payment.js (1)

• docstatus (599-599)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: Python Unit Tests (1)
• GitHub Check: Python Unit Tests (4)
• GitHub Check: Python Unit Tests (2)
• GitHub Check: Python Unit Tests (3)
• GitHub Check: Patch Test
• GitHub Check: Summary

🔇 Additional comments (2)

erpnext/__init__.py (1)

7-7: LGTM! Version bump for release 15.93.1.

The version number update is consistent with the PR objectives and follows proper versioning conventions.

erpnext/controllers/accounts_controller.py (1)

429-434: LGTM! The filter correctly prevents processing cancelled repost documents.

The addition of & (dt.docstatus != 2) ensures that only non-cancelled repost entries are retrieved for reference removal. This prevents the failure when repost_doc.save() attempted to modify a cancelled document during invoice deletion.

The fix is consistent with the earlier validation (lines 412-427) that checks for cancelled entries and is a prudent safeguard to ensure that subsequent processing only handles valid, non-cancelled documents.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ruthra-kumar]

@Gubbu77

Cancelled repost documents are identified only to throw validation error. Not to modify them.