Open
Conversation
Contributor
|
Attach some images of the UI |
Author
Before: 
After: 
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the Skeleton component to better support
flexible presentation requirements commonly needed
in modern UI patterns.
What is the main gain?
This change removes the need for wrapper elements
or inline style workarounds when using Skeletons,
resulting in cleaner markup and more consistent
usage across Frappe UI.
Why is this needed?
Skeletons are widely used as loading placeholders
across different UI surfaces such as user previews,
lists, and contextual components. Without sufficient
flexibility at the component level, consumers are
forced to rely on implementation-specific hacks.
This PR provides a clean, component-level solution
that improves developer experience while keeping
existing usage intact.