fix: add DatePicker support for custom Date/Datetime fields in UniInput#2811
fix: add DatePicker support for custom Date/Datetime fields in UniInput#2811samarth93 wants to merge 2 commits intofrappe:developfrom
Conversation
|
Hi @samarth93, I think this PR will close #2670, right? |
|
@KerollesFathy Yes, this PR fixes both #2669 and #2670 since #2670 is a tracking issue for #2669. The fix adds DatePicker and DateTimePicker support to the UniInput component, which is used in the new ticket form for custom fields. This resolves the issue where Date and Datetime fields were rendering as plain text inputs. Changes made:
Both issues should be resolved with this PR |
Ok, I will close the PR 👍🏼 |
desk/src/components/UniInput.vue
Outdated
| import { parseApiOptions } from "@/utils"; | ||
| import { createResource, FormControl } from "frappe-ui"; | ||
| import { createResource, DateTimePicker, dayjs, FormControl } from "frappe-ui"; | ||
| import DatePicker from "frappe-ui/src/components/DatePicker/DatePicker.vue"; |
There was a problem hiding this comment.
import from frappe-ui not like this
|
@samarth93 |
Fixes frappe#2669 Custom Date and Datetime fields on the new ticket form were rendering as plain text inputs instead of proper DatePicker/DateTimePicker components. Changes: - Import DatePicker and DateTimePicker from frappe-ui - Add handling for 'Date' fieldtype to render DatePicker component - Add handling for 'Datetime' fieldtype to render DateTimePicker component - Add date formatting in transValue for proper display
samarth93
force-pushed
the
fix/datepicker-custom-fields-2669-develop
branch
from
41b71d0 to
f5712e0
Compare
|
@RitvikSardana The workflow is waiting for the approval. Can you approve so I can see if everything is working fine? |
3 participants
Fixes #2669
Custom Date and Datetime fields on the new ticket form were rendering as plain text inputs instead of proper DatePicker/DateTimePicker components.
Changes: