Open
Conversation
Author
|
@RitvikSardana I have made some changes on the issue i had raised earlier about "method/helpdesk.api.doc.get_list_data HTTP/1.1" 500 on Frappe Version 16 #2866 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the Helpdesk app APIs used by the dashboard and document views. The changes focus on making the APIs more consistent, easier to maintain, and better aligned with current frontend usage.
Changes Included
Dashboard API
File:
helpdesk/api/dashboard.pyDocument API
File:
helpdesk/api/doc.pyTesting Performed
bench migrateandbench restartsuccessfullyWhy This Change Is Needed
The previous implementation caused intermittent HTTP 500 errors during normal Helpdesk usage, particularly when loading dashboard data and ticket lists.
Observed issues included:
POST /api/method/helpdesk.api.dashboard.get_dashboard_datareturning intermittent 500 errorsPOST /api/method/helpdesk.api.doc.get_list_dataconsistently returning 500 errors when loading ticket listsThese errors caused partial or broken UI rendering in the Helpdesk dashboard and document views. The refactored APIs address these issues by improving query handling, data validation, and response consistency.