ENH: Test wheels #71
ENH: Test wheels #71
Conversation
| # TODO: once numpy 1 support is dropped, enable these jobs; set to only run on | ||
| # tagged releases, and only if the test.yml workflow is successful |
There was a problem hiding this comment.
I've implemented the "only run on tags" part, assuming you tag with vX.Y.Z.
For the "only if test.yml is successful"... that part is harder. I would suggest to only cut a tagged release after checking that all CIs are green instead. Releases are infrequent enough this usually isn't too onerous an additional release step...
.github/workflows/cibuildwheel.yml
Outdated
| with: | ||
| python-version: ${{ matrix.python }} | ||
| # Choose versions from 2022 (somewhat arbitrarily) | ||
| - run: python -m pip install numpy==1.23 scipy=1.8 nibabel pillow xxhash --only-binary="numpy,scipy,nibabel,pillow,xxhash" |
There was a problem hiding this comment.
I tried to pick "sufficiently old" versions here that still had binary wheels available
.github/workflows/cibuildwheel.yml
Outdated
| # include: | ||
| # - os: ubuntu-latest | ||
| # arch: aarch64 | ||
| os: [ubuntu-latest, ubuntu-24.04-arm, macos-15, macos-15-intel, windows-latest] # windows-11-arm |
There was a problem hiding this comment.
Based on timings from https://github.com/freesurfer/surfa/actions/runs/20828992017/job/59837983745?pr=71, the slowest of all was macos-15 (i.e., Intel macOS) so I don't see any harm in adding ubuntu-24.04-arm (which was itself a touch faster than ubuntu-latest) and windows-latest to the matrix here
1 participant
Implements the ideas from #66 (comment)
Happy to iterate, or close if this stuff isn't needed. But I am curious to make sure it all works myself as well!