This repository was archived by the owner on Jun 21, 2019. It is now read-only.
Make checks for undefined values more robust. #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had some issues with the nodelist breaking in case some values were not `undefined`, but `null` instead. The comparison `typeof value != 'undefined'` doesn't help here, so we got errors like "f.autoupdater is null". I replaced `typeof value != 'undefined'` with `value != null`, which catches both `undefined` and `null` values, and seems to be a good way to check for both those values, according to https://stackoverflow.com/questions/2559318/how-to-check-for-an-undefined-or-null-variable-in-javascript
Author
|
FYI: Fixed a typo, missing ) |
Contributor
|
@Skrupellos would be nice to have this merged ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some issues with the nodelist breaking in case some values were
not
undefined, butnullinstead.The comparison
typeof value != 'undefined'doesn't help here, so wegot errors like "f.autoupdater is null".
I replaced
typeof value != 'undefined'withvalue != null, whichcatches both
undefinedandnullvalues, and seems to be a good wayto check for both those values, according to
https://stackoverflow.com/questions/2559318/how-to-check-for-an-undefined-or-null-variable-in-javascript
This PR supersedes #14