feat(filtering): Bump FirestoreStorage dependency and enable Firestore Filter capabilities #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing capabilities with Filters
dominicbartl
requested changes
Jan 23, 2025
|
|
||
| where(prop: WhereProp<T>, op: Op, value: any) { | ||
| return this.applyWhere(this.getWhereProp(prop), op, value); | ||
| where(propOrFilter: WhereProp<T> | Filter, op?: Op, value?: any) { |
Member
There was a problem hiding this comment.
The firestore-storage-core package is also used in frontend applications. Is it possible to move that implementation to the storage package?
Author
There was a problem hiding this comment.
Just copying it as is into the storage package?
Member
There was a problem hiding this comment.
I guess it works, if you override the where method into the storage package
| "reflect-metadata": "^0.1.13", | ||
| "ts-object-path": "^0.1.2" | ||
| "ts-object-path": "^0.1.2", | ||
| "@google-cloud/firestore": "^7.11.0" |
Member
There was a problem hiding this comment.
That dependency would not work in the browser
Author
There was a problem hiding this comment.
Damn - Forgot about web. A generic "Filter" class or type can be made instead of relying on the type from this import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Filter.orandFilter.andcapabilities. The Abstract classes were updated to accommodate these updates