Repository navigation
Download dev sources outside the shared web root - #332
nupplaphil wants to merge 2 commits into
Conversation
The tarball was written to the working directory /var/www/html, which is a volume shared by every container of an installation. Containers starting at the same time overwrote each other's download and failed with a truncated archive or a bad signature.
|
Never had that problem. Do you have multiple Friendica containers running in parallel (the cron variant doesn't count as it does not use the docker-entrypoint-dev.sh script) ? |
|
Yes. I'm running cron and 4 appContainer in parallel for Performance purpose. And all starts downloading the sources in parallel which lead to these errors :) |
|
I see. I just have a single app container and one for cron. With this it is writing to the conatiners overlay volume. We do this in other places as well ... so I assume it is okay. |
|
It's not a setting for each Container. The Container span just with one config in docker compose and it spans automatically each insurances |
|
I see. I have limited knowledge of compose as I use podman with systemd for my systems. But how about duplicating the section? I would think of something like spanning up one container as main container first (with the update), then the cron container, then the other three afterwards. Shouldn't that be possible? |
|
This is how kubernetes works with an "init" Container. I'll give it a try Nevertheless I think this is an improvement so there's no race condition at one directory |
The dev/rc entrypoint downloads the tarball into the working directory
/var/www/html, which is a volume shared by every container of an installation. Containers starting at the same time overwrite each other's download and fail with a truncated archive or a bad signature.Changes:
Found in my instance (friendica.me)