Skip to content

run setup code early if writeValue has content. fixes #331 #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

run setup code early if writeValue has content. fixes #331 #454

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cd1e89
run setup code early if writeValue has content. fixes #331
Jan 3, 2021
81cde31
set initialized to true
Jan 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/editor/editor.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ export class FroalaEditorDirective implements ControlValueAccessor {
// Form model content changed.
writeValue(content: any): void {
this.updateEditor(content);
if(content){
this.setup();
}
}

registerOnChange(fn: (_: any) => void): void { this.onChange = fn; }
Expand Down Expand Up @@ -346,6 +349,15 @@ export class FroalaEditorDirective implements ControlValueAccessor {
// TODO not sure if ngOnInit is executed after @inputs
ngAfterViewInit() {
// check if output froalaInit is present. Maybe observers is private and should not be used?? TODO how to better test that an output directive is present.
this.setup();
}

private initialized = false;
private setup() {
if (this.initialized) {
return;
}
this.initialized = true;
if (!this.froalaInit.observers.length) {
this.createEditor();
} else {
Expand Down