Rory-Walsh-V4.0.5-patch-1 #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torInstance, so now has support for multiple editors on same page.
Removed the config option changing VIDEO_EMBED_REGEX from previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed broken syntax errors, moved away from using a global "editorInstance",
so now has support for multiple editors on same page.
This version works, the current version does not, and has multiple syntax errors e.g. unclosed if blocks.
Documentation usage would need updating, because the notion of using a "froalaInstance" binding is no longer required. The "froalaInstance" binding appears to be an attempt at having multiple editors co-exist on the same page, but the approach was to duplicate and store each editor in an observable on each KO model, and update the global "editorInstance" variable throughout.
As above, the implementation would not of worked anyway.