Fix: --allow-*フラグ指定を改善 - #2
Open
ThinaticSystem wants to merge 3 commits into
Open
Conversation
- `--allow-read`フラグが不要に - `--allow-run`フラグで対象コマンドを指定
ThinaticSystem
force-pushed
the
fix/thinatic/allow-flags
branch
from
May 3, 2025 03:43
6cf7249 to
87cec35
Compare
ThinaticSystem
marked this pull request as ready for review
May 3, 2025 03:44
marihachi
approved these changes
May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
各種Deno Tasksの
--allow-*フラグが物騒What
ローカル環境において.envファイルを実行時に読み込ませるのをやめ
--env-file=オプションで注入するように変更→
--allow-readフラグが不要に※Deno Deploy環境においては動作時に必要な環境変数をEnvironment Variablesで定義しておく必要があります (追加済み)
--allow-runフラグにコマンドを指定→実行できるプログラムを
deployctlのみに制限