Open
Conversation
Contributor
Author
|
@Tarmil any remarks? |
Tarmil
requested changes
Dec 17, 2023
| open System | ||
|
|
||
| [<AttributeUsage(AttributeTargets.Parameter ||| AttributeTargets.Field)>] | ||
| type internal TimeSpanConstantAttribute(miliseconds) = |
Member
There was a problem hiding this comment.
I'm guessing this attribute is supposed to provide the default value for an optional parameter, but I can't get it to work on toy examples, nor find any documentation about using custom operators for this.
| static member UseHotReload(this: IEndpointRouteBuilder, [<Optional; DefaultParameterValue(HotReloadConstants.DefaultUrl)>] urlPath: string) : unit = | ||
| this.ServiceProvider.GetService<Watcher>().Start() | ||
| let urlPath = defaultArg urlPath HotReloadSettings.Default.Url | ||
| let urlPath = urlPath |
Member
There was a problem hiding this comment.
Might as well remove this line altogether.
Tarmil
force-pushed
the
master
branch
2 times, most recently
from
57b6fba to
f54a66b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #18