Skip to content

Conversation

@Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Oct 24, 2025

And Expecto.FsCheck and the test adaptor to the matching versions.

Description

This was originally a plan to break out a bit more of the .NET 8 PR into a self contained change and to pick up an optimization I made to Expecto to speed up test discovery, but when doing it I noticed that the existing change in #2818 is also disabling the timeouts that have been applied to the test runs, so this version tries to do the update whilst retaining those.

The Expecto dependency here should be internal to the unit tests, so it shouldn't have a public effect in the Fake modules (The Fake.DotNet.Testing.Expecto module doesn't depend on Expecto itself)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

Test Results

   12 files     12 suites   33m 6s ⏱️
  451 tests   450 ✅ 1 💤 0 ❌
1 287 runs  1 284 ✅ 3 💤 0 ❌

Results for commit 329340d.

♻️ This comment has been updated with latest results.

And Expecto.FsCheck and the test adaptor to the matching versions.
@xperiandri xperiandri merged commit 18d84a9 into fsprojects:master Oct 25, 2025
5 checks passed
@Numpsy Numpsy deleted the expecto_up branch October 25, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants