-
Notifications
You must be signed in to change notification settings - Fork 68
More aligned with Microsoft maintenance #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…em.Data.SqlClient to 4.9.0, Added TrustServerCertificate to connectionstrings, added
|
Thanks @Thorium, I'll try to pay a look soon, but we should be fine with such minor in-place updates like this, so long we clear all the tests in dev environment and appveyor, but somehow it seems the appveyor CI is not showing up for some reason. I'll try to see what is up with this. I had made some efforts to try to setup github actions, but it was only a first attempt, maybe you are more familiar and could try a bit of nudging? |
|
My main motivation was a) support both .NET 8 and .NET Full (done) and, b) to try to split Microsoft.Data.SqlClient update: Because it has already been tried twice here, maybe we can move in that direction with smaller steps at a time. I went on Microsoft.Data.SqlClient an initial trial with a branch https://github.com/Thorium/FSharp.Data.SqlClient/tree/microsoft-data-sqlclient which is 2 commits ahead of this, but it's not yet in PR-ready working condition. It compiles but some of the TestProjects (non-Lib) projects fail, and some unit-tests fail. But I also have a working type provider with Microsoft.Data.SqlClient: https://github.com/fsprojects/SQLProvider/tree/split-providers2 and NuGet https://www.nuget.org/packages/SQLProvider.MsSql/1.5.0-alpha3 so this should be doable with FSharp.Data.SqlClient as well. |
Fixes for Samples.sln
|
@Thorium, I checked the branch and it seems to be flying green on a local build, thanks for the help. I'm attempting to adjust the AppVeyor CI, which requires jiggling things with the authentication and maybe some help from people handling fsprojects organization on github. Are there more things we'd want in this PR? Should we make a minor release once merged? |
|
I think minor release could be good. |
|
https://www.nuget.org/packages/FSharp.Data.SqlClient/2.1.3 will be online in a bit. |
Moved .NET Framework Full 4.0 to .NET Framework Full 4,6.2
Changed F# core to 8.0.301
Updated System.Data.SqlClient to 4.9.0
Added TrustServerCertificate to connectionstrings, added
This contains the changes of #438 so if merging this, the other one can be closed.