Fix compile errors in fsyacc's output if there is no header in the input file.#228
Merged
nojaf merged 2 commits intofsprojects:masterfrom Dec 23, 2024
Merged
Conversation
…put file. And remove the header from the mini project as a test.
teo-tsirpanis
force-pushed
the
fix-no-header
branch
from
cb8bedb to
2cf9d2e
Compare
Collaborator
|
Could you please explain what this does? In what situations is this beneficial? |
Contributor
Author
|
Updated PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header in
.fsyfiles is optional. However if it does not exist, FsYacc will emit a#0 ""line directive in the source file, and the compiler will not like the empty string in the file name. This PR fixes FsYacc to not emit any line directives if the header is empty.Validated by removing the header from the mini project.