Add "generate_path_property" option#4292
Open
sin-ack wants to merge 2 commits intofsprojects:masterfrom
Open
Conversation
This replicates the behavior of <PackageReference GeneratePathProperty="true" /> in Paket. This is required in certain edge cases, such as when creating a source generator project that needs to reference third-party assemblies.
With this, the "generate_path_property" option takes effect and we are able to render the XML file with the GeneratePathProperty attribute on the PackageReference.
Author
|
Hmm, I learned after opening this that apparently it is possible to enable this without Paket integration using ItemDefinitionGroup: <ItemDefinitionGroup>
<PackageReference>
<GeneratePathProperty>true</GeneratePathProperty>
</PackageReference>
</ItemDefinitionGroup>If this PR is unnecessary after this, feel free to close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replicates the behavior of
<PackageReference GeneratePathProperty="true" />in Paket. This is required in certain edge cases, such as when creating a source generator project that needs to reference third-party assemblies.Tests have been added for verifying the option in the lockfile, paket.dependencies/paket.references files and to verify the output in the generated
paket.propsfiles.