Avoid compacting/merging attributes on recursive type definitions when trivia is present#3176
Draft
tboby wants to merge 9 commits intofsprojects:mainfrom
Draft
Avoid compacting/merging attributes on recursive type definitions when trivia is present#3176tboby wants to merge 9 commits intofsprojects:mainfrom
tboby wants to merge 9 commits intofsprojects:mainfrom
Conversation
nojaf
reviewed
Aug 2, 2025
|
|
||
| items |> List.fold folder [] |> List.map List.rev |> List.rev | ||
|
|
||
| let genCompactedAttributes (n: MultipleAttributeListNode option) = |
Contributor
There was a problem hiding this comment.
Could you add a code comment on what this does?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still WIP
Fixes #3174
Please verify your pull request is respecting our Pull request ground rules.
You can find more information in our Contributors documentation section.