Fantomas tool path safety checks #3195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting their own program as fantomas-tool
|
I'm not sure I want this, do you have an actual use-case for this? |
|
This is theoretical security issue. I don't know the best solution. I'm lucky enough to not have seen any real-life usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential security issue:
Someone could do some remote code execution attack by injecting their own program as fantomas-tool. Then execute that on part of build process via whatever new codebase repository build the victim is executing.
This PR adds some extra checks to pick the fantomas-tool.
Better than nothing, but this is not going as far as e.g. strong-name checks.