Fix wrong results of hasMessageAvailable after seeking by timestamp #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lanayx
reviewed
Oct 29, 2025
| and private set value = Volatile.Write(&lastMessageIdInBroker, value) | ||
|
|
||
| member this.HasSoughtByTimestamp | ||
| with get() = Volatile.Read(&hasSoughtByTimestamp) |
There was a problem hiding this comment.
The HasSoughtByTimestamp property is unused, so not needed
tests/IntegrationTests/Reader.fs
Outdated
|
|
||
| // The Seek operation does not implement a backoff mechanism. It will fail if the connection is not | ||
| // ready, so wait for a short period until the connection becomes available. | ||
| do! Async.Sleep(1000) |
There was a problem hiding this comment.
Please use Task.Delay here and below
Lanayx
approved these changes
Oct 30, 2025
|
Thank you, released 3.12.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bring this fix apache/pulsar#22363 to the pulsar-client-dotnet
The reader's HasMessageAvailableAsync may return true after a timestamp-based seek, even if there are no available messages in the topic.
Modifications
Add a boolean flag
HasSoughtByTimestampto represent whether the last seek call accepts a timestamp. If it's true, don't takestartMessageIdinto comparison withlastMessageIdInBroker, just compare the mark-delete position and last position in the GetLastMessageId response.