Personal tool to split up large intervals in an interval list. - #1100
Open
tfenne wants to merge 1 commit into
Open
Personal tool to split up large intervals in an interval list.#1100tfenne wants to merge 1 commit into
tfenne wants to merge 1 commit into
Conversation
|
nh13
approved these changes
Sep 29, 2025
| @clp(group=ClpGroups.Personal, description= | ||
| """ | ||
| |Splits intervals within an interval list. Consumes an input interval list and attempts to break it | ||
| |into _at least_ `--num-intervals` intervals. The resulting interval list will likely end up with additional |
Member
There was a problem hiding this comment.
Suggested change
| |into _at least_ `--num-intervals` intervals. The resulting interval list will likely end up with additional | |
| |into _at least_ `--num-intervals` intervals of approximately equal size. The resulting interval list will likely end up with additional |
| |intervals. | ||
| | | ||
| |Calculates a max interval size by summing the length of all input intervals and dividing by the desired | ||
| |number of output intervals. Then each input interval is is broken up into approximately equals size, |
Member
There was a problem hiding this comment.
Suggested change
| |number of output intervals. Then each input interval is is broken up into approximately equals size, | |
| |number of output intervals. Then each input interval is is broken up into approximately equal size, |
| |Calculates a max interval size by summing the length of all input intervals and dividing by the desired | ||
| |number of output intervals. Then each input interval is is broken up into approximately equals size, | ||
| |non-overlapping, sub-intervals of no more than the max size. | ||
| """) |
Member
There was a problem hiding this comment.
I found the usage very confusing, sorry. Perhaps something like, takes in a interval list, and tries splitting intervals such that the output interval list has at least --num-intervals intervals. If the interval list already has at least this number, nothing is done (is this true?)
yfarjoun
reviewed
Sep 30, 2025
| |into _at least_ `--num-intervals` intervals. The resulting interval list will likely end up with additional | ||
| |intervals. | ||
| | | ||
| |Calculates a max interval size by summing the length of all input intervals and dividing by the desired |
Contributor
There was a problem hiding this comment.
Suggested change
| |Calculates a max interval size by summing the length of all input intervals and dividing by the desired | |
| |Calculates a max interval size by taking the size of the covered territory and dividing by the desired |
yfarjoun
approved these changes
Sep 30, 2025
yfarjoun
left a comment
yfarjoun
left a comment
Contributor
There was a problem hiding this comment.
The code does what I expect, the documentation I leave to the english speakers...
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1100 +/- ##
=======================================
Coverage 95.86% 95.86%
=======================================
Files 131 131
Lines 7884 7884
Branches 547 547
=======================================
Hits 7558 7558
Misses 326 326
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Personal tool used once to break up an interval list for a project, that's here for posterity.