Remove VariantContexts from most fgbio tools - #836
Open
kstromhaug wants to merge 7 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## main #836 +/- ##
==========================================
+ Coverage 95.58% 95.71% +0.12%
==========================================
Files 122 125 +3
Lines 7068 7282 +214
Branches 511 490 -21
==========================================
+ Hits 6756 6970 +214
Misses 312 312
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kstromhaug
changed the base branch from
main
to
ks_remove_variantcontextsetbuilder
April 29, 2022 20:25
kstromhaug
force-pushed
the
ks_rm_variant_contexts
branch
from
April 29, 2022 20:34
c81cca1 to
10f997f
Compare
kstromhaug
marked this pull request as ready for review
April 29, 2022 20:56
nh13
removed their request for review
September 25, 2025 22:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to
To remove
VariantContexts and other elements of HTSJDKand associated tests
MakeMixtureVcfhas a modified line so that everything will compile, but still passes all tests which is a little concerning.