feat: add home, end, and delete cursor functionality#57
Open
BendikMann wants to merge 4 commits intofunbiscuit:masterfrom
Open
feat: add home, end, and delete cursor functionality#57BendikMann wants to merge 4 commits intofunbiscuit:masterfrom
BendikMann wants to merge 4 commits intofunbiscuit:masterfrom
Conversation
feat: add home, end, and delete cursor functionality
|
Hi @funbiscuit, since @BendikMann has already rebased the changes in #57, we can proceed with that PR instead. I'll close this one to avoid duplication. Thanks! |
funbiscuit
requested changes
Feb 22, 2026
Owner
funbiscuit
left a comment
funbiscuit
left a comment
There was a problem hiding this comment.
Can you please add some tests for new commands? Look inside tests/cli files for reference. Probably can be easily vibecoded using existing reference.
It would be also great if you add tests for --help/-h option, they're missing, that's why removal of --help/-h option was not catched by tests.
Comment on lines
-881
to
-885
| // check if help was requested (help is printed when no other options are set) | ||
| if (cmdArgs != NULL && (strcmp(cmdArgs, "-h") == 0 || strcmp(cmdArgs, "--help") == 0)) { | ||
| printBindingHelp(cli, &impl->bindings[i]); | ||
| } else { | ||
| impl->bindings[i].binding(cli, cmdArgs, impl->bindings[i].context); |
Owner
There was a problem hiding this comment.
Maybe this should not be removed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of the pull request @gary7530 initially submitted, but did not complete the merge that @funbiscuit requested.
@gary7530's original pull request:
Please let me know if any additional changes are required.