Skip to content

Improve BenchmarkText_lineBounds_xxx#6240

Merged
dweymouth merged 2 commits intofyne-io:developfrom
MaxGyver83:improve-BenchmarkText_lineBounds-benchmarks
Mar 31, 2026
Merged

Improve BenchmarkText_lineBounds_xxx#6240
dweymouth merged 2 commits intofyne-io:developfrom
MaxGyver83:improve-BenchmarkText_lineBounds-benchmarks

Conversation

@MaxGyver83
Copy link
Copy Markdown
Contributor

Description:

Reset the font metrics cache before every lineBounds benchmark run. Otherwise, the first run is slow and all further are fast because they can use the cached measurements of the first run.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style and have Since: line.

Reset the font metrics cache before every lineBounds benchmark run.
Otherwise, the first run is slow and all further are fast because they
can use the cached measurements of the first run.
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 31, 2026

Coverage Status

coverage: 60.4% (-0.4%) from 60.808%
when pulling f412e4d on MaxGyver83:improve-BenchmarkText_lineBounds-benchmarks
into 33a4ea1 on fyne-io:develop.

@dweymouth dweymouth merged commit 1d0fd53 into fyne-io:develop Mar 31, 2026
11 checks passed
@MaxGyver83 MaxGyver83 deleted the improve-BenchmarkText_lineBounds-benchmarks branch April 1, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants