Fix coding mode Git safety enforcement#14
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: g00sifer Development Lab <g00siferdev-py@users.noreply.github.com>
Co-authored-by: g00sifer Development Lab <g00siferdev-py@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
coding_run_commandshell path allowedgit push --force/ force refspecs, bypassing the dedicated push tool's force-push protection and risking remote history loss.http://, allowing a saved PAT to be sent over cleartext HTTP.Root cause
run_coding_tool.https://andhttp://despite PAT-backed Git operations requiring HTTPS.Fix
coding_run_commandGit invocations.https://.Validation
cargo +stable test --manifest-path src-tauri/Cargo.toml validate_cargo +stable test --manifest-path src-tauri/Cargo.toml coding_tools_fail_closed_without_settingscargo +stable test --manifest-path src-tauri/Cargo.toml