Fix coding git remote auth validation#16
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: g00sifer Development Lab <g00siferdev-py@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Coding remote git tools attached the saved GitHub PAT to arbitrary
remotevalues and clone URLs, including plaintext HTTP or attacker-controlled hosts.coding_git_pushalso accepted raw refspec-like branch values such as:main, allowing remote branch deletion despite the tool being intended for normal branch pushes.Root cause
The URL guard only checked string prefixes and allowed
http://plus any host. Push/pull/fetch treated model-suppliedremoteandbranchstrings as direct git arguments before validating that the remote was a configured GitHub HTTPS remote or that the branch was a simple branch name.Fix
https://github.com/....HEAD, or invalid branch names.Validation
cargo test git_auth --lib(passed: 3 tests).