Fix workspace citation path escape#3
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: g00sifer Development Lab <g00siferdev-py@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Artifact citation buttons passed model-provided paths directly to the
open_pathTauri command. Becauseopen_pathaccepted absolute paths and did not canonicalize/validate workspace containment, a crafted citation could make the app open an arbitrary local file or folder when clicked.Root cause
open_pathonly trimmed the string, accepted absolute paths as-is, and joined relative paths to the workspace without reusing the workspace path jail used by agent tools.Fix
workspace/...citation paths and workspace-relative paths...traversal, and symlink escapes before invoking the OS opener.Validation
cargo +stable test open_path --locked— 4 regression tests passed.cargo +stable test --locked— 35 Rust tests passed.